search

StackStorm / st2web

StackStorm Web UI
http://www.stackstorm.com/features
Apache License 2.0
103 stars 82 forks source link

Added task retry model feature to task properties. #859

Closed shital-orchestral closed 3 years ago

shital-orchestral commented 3 years ago

Added Retry Feature as a new field under task properties.

amanda11 commented 3 years ago

@m4dcoder @shital-orchestral LGTM. I found no problems with this PR, you can set negative numbers, but as per the other PR I think that is a limitation we have with other fields, and where we need to allow expression support not worth trying to resolve.

I found a bug when testing it but confirmed that that problem also exists on the master branch - so not to do with this PR. But it's an interesting bug as there are problems with Save, Execute, Save if your workflow has an input parameter: https://github.com/StackStorm/st2web/issues/862. I have confirmed that this was NOT a problem with 3.2

m4dcoder commented 3 years ago

@amanda11 Here's a screen shot of the UI with an example where count is -100 and a validation error at the bottom of the canvas.

Screen Shot 2021-03-29 at 10 57 21 AM
amanda11 commented 3 years ago

Looks good - thanks for changes