search

StackStorm / st2web

StackStorm Web UI
http://www.stackstorm.com/features
Apache License 2.0
102 stars 83 forks source link

fix: Save workflow error when updating with parameters #961

Closed JazzyMichael closed 2 years ago

JazzyMichael commented 2 years ago

Fixes issue 862

Saving a workflow immediately after creating and running it causes a 400 HTTP response code for a bad request. There is an extra property in the PUT request body that is not supported by the API. Finer details and replication steps can be found within the issue. These changes removes the _name property from the request body, resulting in a successful "save".

This also fixes some react errors regarding ref; it cannot be used for function components, and the _details variable is not defined either.

React Error Example (when loading multiple pages): Screen Shot 2022-02-28 at 10 14 37 AM

amanda11 commented 2 years ago

This looks great to me, just needs a rebase to pick up latest from master.

I would like to give the changes a try before approval- hope to take it for spin later in week (unless someone else gets to review earlier than that).