StackStorm / st2web

StackStorm Web UI
http://www.stackstorm.com/features
Apache License 2.0
103 stars 82 forks source link

Search Criteria Support in the Web UI #964

Closed JazzyMichael closed 2 years ago

JazzyMichael commented 2 years ago

Resolves: 492

Adds support for Search Criteria and nested parameter fields for rules.

This recording demonstrates the current application without the "search" option in the UI. Since search functionality is implemented in the back-end but not the front-end, navigating to a rule that uses search crashes the application.

https://user-images.githubusercontent.com/46300738/162856765-e75741b7-d062-4287-a315-042542fdb7d5.mov

This next recording demonstrates the changes: Added search criteria input fields, as well as not crashing the app when selecting a rule using search:

https://user-images.githubusercontent.com/46300738/162855561-76fe2216-f97f-4af3-a95a-f21bdea9db07.mov

pradnya-orchestral commented 2 years ago

@Jappzy , I have tested your changes, if we are selecting search from dropdown list, then condition is mandatory fields, so there should be some parameter field need to send from UI while saving data in PUT API to backend, so that we can get something for condition parameter in GET API. Here, need to check this because we are not getting anything for condition parameter in Get API so that on UI it is showing empty, I have made red square to highlight in following screenshot. Can you please check this?

condition screen

JazzyMichael commented 2 years ago

@pradnya-orchestral Could you re-test? I added a screen recording and fixed the default values getting included in the PUT request.

mickmcgrath13 commented 2 years ago

@pradnya-orchestral are you able to re-review?

@Jappzy once things are good, we'll need to merge master -> this branch

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nzlosh commented 2 years ago

@pradnya-orchestral have you been able to test since @Jappzy applied the fixes for the problem you mentioned?