Handle cases where `content-type` is not exactly `application/json`

[luislobo]

Fixes https://github.com/StackStorm/st2web/issues/981

Our production Nginx configuration has set charset utf-8; making Content-Type header to be application/json; charset=utf-8, not just application/json. @stackstorm/module-api compares headers['content-type'] to be exactly application/json.

Some comments about the request function:

• It seems like it's been migrated from st2client.js
• @key10 and I reviewed it and it seems like there is an opportunity to improve it

Some possible improvements/questions:

1. Should raw return the data without doing any JSON.parse? If so, then transformResponse should not be used.
2. On line 234, body is assigned data. Assuming data is a string at this moment, body is not a pointer of data, but rather a copy. Then, the changes done on body on lines 244-248 (for parsing JSON) are superfluous, since the function is returning data.
3. Line 232 could be done before 229, and not have to repeat defaulting to {} on both 229 and 230.

Let us know about those comments/questions and we can apply changes as needed.

[luislobo]

@amanda11 @armab

I'd appreciate if you can check this one out when you have a chance.

Thank you

[amanda11]

think I've found the problem with st2web, and I'm looking at a PR to fix.

[amanda11]

@luislobo If you can merge in latest master this should hopefully build ok now.

[luislobo]

Sure, will do.

[luislobo]

Seems like tests passed now :)