Closed luislobo closed 2 years ago
@amanda11 @armab
I'd appreciate if you can check this one out when you have a chance.
Thank you
think I've found the problem with st2web, and I'm looking at a PR to fix.
@luislobo If you can merge in latest master this should hopefully build ok now.
Sure, will do.
Seems like tests passed now :)
Fixes https://github.com/StackStorm/st2web/issues/981
Some comments about the request function:
Some possible improvements/questions:
raw
return the data without doing any JSON.parse? If so, thentransformResponse
should not be used.body
is assigneddata
. Assumingdata
is a string at this moment,body
is not a pointer ofdata
, but rather a copy. Then, the changes done onbody
on lines 244-248 (for parsing JSON) are superfluous, since the function is returningdata
.{}
on both 229 and 230.Let us know about those comments/questions and we can apply changes as needed.