GCP metadata logging cleanup

dhrupadb commented 7 years ago

Make logs more informative when running on AWS. As GCP gets checked first, customers may interpret the message from the metadata server as an error.

igorpeshansky commented 7 years ago

Can we build a test package to validate this change?

dhrupadb commented 7 years ago

Built a package and validated it on an ec2 instance. One question - there's still a "Unsuccessful HTTP request" logged by wg_curl_get_or_post . To make it clear to the user that the error was benign

Add another line of logging in wg_get_from_gcp_metadata_server and wg_get_from_aws_metadata_server pointing out that we succeeded in finding metadata associated with that provider.

OR

Do the same thing for wg_curl_get_or_post. Add a ignore_failure flag which doesn't log the unsuccessful HTTP request message conditionally.

Thoughts?

igorpeshansky commented 7 years ago

I'd vote for the latter. @qingling128 and @bmoyles0117, opinions?

qingling128 commented 7 years ago

The latter sounds good to me. As to the name ignore_failure, how about expect_failure?

dhrupadb commented 7 years ago

PTAL. Confirmed that change is WAI.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

igorpeshansky commented 5 years ago

dhrupadb was at Google at the time.

Stackdriver / collectd