search

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).
https://cloud.google.com/monitoring/agent/
Other
51 stars 15 forks source link

Add grpc and status code info in request and entry count metrics. #125

Closed qingling128 closed 6 years ago

qingling128 commented 6 years ago

This depends on https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/186 to be merged and released first.

qingling128 commented 6 years ago

Restore having 200 and 0 codes explicitly due to the change in https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/186/commits/22e9921119c36eceb6b594e5e846ead06d065125.

qingling128 commented 6 years ago

PTAL.

qingling128 commented 6 years ago

Any additional comment on this one or is it good to go?

igorpeshansky commented 6 years ago

Have you responded to this comment?

qingling128 commented 6 years ago

Addressed. PTAL.

qingling128 commented 6 years ago

Sure. I added a note in that bug. Will merge this one.