search

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).
https://cloud.google.com/monitoring/agent/
Other
51 stars 15 forks source link

Varnish 5.2 compatibility changes taken from collectd#2527 #134

Closed gbprz closed 6 years ago

gbprz commented 6 years ago

This contains cherry picked commits from collectd#2527. While working on the build for Ubuntu Bionic, I noticed there are no packages available for libvarnishapi-dev versions lower than 5.2. Pulling in Xenial sources seemed like an incorrect approach.

Note: the build script will need to be run since this makes changes to the autoconf configure script. I have a few open branches for required Bionic build changes and at least one of them also requires running the build script. To avoid merge conflicts, I left this commit out of this PR until everything is merged into the "gabeperez-bionic-build-changes" feature branch. My idea was to run the build script once everything is merged into that branch. Please let me know if you would prefer I include this commit instead.

igorpeshansky commented 6 years ago

Let's rebase on top of stackdriver-agent-5.5.2 to pick up the fixes from #135.

gbprz commented 6 years ago

All set, checks are passing now

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

igorpeshansky commented 5 years ago

This is a cherrypick of upstream commits.

viable-hartman commented 5 years ago

Did this actually get merged? I'm running Varnish 5.2 and have the 5.5.2-384 stack driver installed, but the varnish.so library still says:

varnish.so: /lib64/libvarnishapi.so.1: version `LIBVARNISHAPI_1.0' not found (required by /opt/stackdriver/collectd/lib64/collectd/varnish.so)

...and won't load the varnish plugin.

igorpeshansky commented 5 years ago

@viable-hartman, this should be merged. Could you please open a new issue and mention the Linux distro where you're experiencing this? Also, the output of ldd /opt/stackdriver/collectd/lib64/collectd/varnish.so would help. Thanks!