search

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).
https://cloud.google.com/monitoring/agent/
Other
51 stars 15 forks source link

Travis build - distcheck missing man pages target, missing header in dist tarball, and clang errors #135

Closed gbprz closed 6 years ago

gbprz commented 6 years ago

I ran into Travis build issues with my pull requests for building on Ubuntu 18.04 (#131, #132, #133, #134). After reproducing the issue on a local Travis testing environment, I noticed the issue also happened on the default branch stackdriver-agent-5.5.2.

I didn't catch these issues earlier since Travis runs extra steps with distcheck:

  1. Libmongoc: dist-hook had a missing target "man" used to include man pages. We already have commented out the inclusion of man pages (f0ffe3b22b5647aa0ceb6f8ffd58782644fc05eb) so I also commented out the included docs Makefile to fix this.
  2. The stackdriver-agent-keys header file was missing from the distribution tarball build during distcheck. I updated the Makefile to include this.
  3. There were also a few warnings/errors that only came up with clang that I needed to address in order for the build to work as well. There was an implicit conversion error (from double to int) in the collectd daemon/plugin.c file and a duplicate const declaration error in write_gcm.

Please let me know if there is a different branch I should merge these changes into. I can merge them into my bionic build feature branch (gabeperez-bionic-build-changes) instead if that's preferred.

gbprz commented 6 years ago

Are there any remaining changes or is this ready to go?