search

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).
https://cloud.google.com/monitoring/agent/
Other
51 stars 15 forks source link

Removed references to `ping` plugin #141

Closed jkohen closed 5 years ago

jkohen commented 5 years ago

We don't bundle it in the Stackdriver agent.

jkohen commented 5 years ago

@igorpeshansky because this one is prominently explained at the top of the documentation and we got internal customer feedback that this was confusing. I can share it with you if you'd like to see it.

It might be a good idea to clean up more plug-ins. Please follow up with a PR doing the rest of the clean-up, since I don't have the information needed to do it.

igorpeshansky commented 5 years ago

All other collectd packages include the full man page, even with plugins that aren't bundled. I believe we should address this in the documentation for the agent package at https://cloud.google.com/monitoring/agent, rather than diverge further from upstream in the source repo. Besides, this change is error-prone in that if we ever do decide to bundle the ping plugin (which we've also been asked to do via customer feedback), we'd have to remember to go back and undo it. If you feel that it's confusing to have unbundled plugins in the man pages, you should instead open a feature request in the upstream repo to hide man page sections for plugins that weren't enabled during the build, and we'll pick it up via the work @nina-marie is doing.

jkohen commented 5 years ago

Given your answer, I'll close this PR. Please deal directly with the customers giving feedback.