search

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).
https://cloud.google.com/monitoring/agent/
Other
51 stars 15 forks source link

Defork collectd #143

Closed nmdayton closed 5 years ago

nmdayton commented 5 years ago

Brings Stackdriver's collectd fork in line with the main collectd repo.

bsiegert commented 5 years ago

How feasible would it be to get rid of the fork altogether and have the write_gcm plugin (which, I gather, is what makes the stackdriver integration work at all) be a standalone repo, requiring an upstream collectd installed?

(As a packager, this would be much nicer, given that we already have a working collectd port in pkgsrc.)

igorpeshansky commented 5 years ago

@bsiegert Unfortunately, this isn't how collectd plugins work. They are required to be built along with the collectd binary (except for some rare cases like plugins written in another language). We've toyed with the idea of maintaining a separate repo for the write_gcm plugin and pulling in upstream collectd via a git submodule, but the work in this PR is a prerequisite for that happening in any case. Another possibility is to converge upstream's write_stackdriver and our write_gcm to the point where we can simply use the upstream codebase. At the moment, however, none of those are actual planned work.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

igorpeshansky commented 5 years ago

Closing in favor of #150.