Run unit tests under address checker

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).

https://cloud.google.com/monitoring/agent/

Other

51 stars 15 forks source link

Run unit tests under address checker #159

Closed jkohen closed 4 years ago

jkohen commented 4 years ago

@igorpeshansky do you have any insights on why this PR fails in make check with "fatal error: mongoc.h: No such file or directory"? I would have thought that the pre-existing make distcheck would have covered that scenario and not be different from make check in this regard.

igorpeshansky commented 4 years ago

Looks like it failed because it tried to build write_mongodb. We never build it in our package, so I'm not surprised that it's broken when using our bundled libmongoc version. We could (a) try building only the plugins we care about from debian/rules, or (b) use a newer distro (e.g., Bionic) with the system libmongoc instead.

jkohen commented 4 years ago

@igorpeshansky I chose xenial because that's what upstream is using, and I borrowed some of their .travis.xml. I had to add -ldl which upstream doesn't seem to need; they might have fixed it in the Makefile, but that's for another time...