Check success of getpwuid_r before using its result.

Stackdriver / collectd

Stackdriver's monitoring agent based on collectd (http://collectd.org).

https://cloud.google.com/monitoring/agent/

Other

51 stars 15 forks source link

Check success of getpwuid_r before using its result. #65

Closed coreykosak closed 8 years ago

coreykosak commented 8 years ago

It can happen that /proc/$PID/status can return a Uid that getpwuid_r can't resolve. One notable scenario is when using Docker, as discussed here.

https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/gc-monitoring-beta-discussion/usp1iaInChg/Ds2tgpLmGQAJ

coreykosak commented 8 years ago

notifying @igorpeshansky

coreykosak commented 8 years ago

I'm going to go ahead and push this to head (stackdriver-agent-5.5.0) because I'd like it to get inside the next release. Let me know if you have any objections.

katzj commented 8 years ago

LGTM