search

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
120 stars 43 forks source link

Removed obsolete comment. #165

Closed jkohen closed 5 years ago

jkohen commented 5 years ago

The intended behavior was always to block. Dropping data was one of the problems with the original remote storage that we intended to solve with our integration design (go/stackdriver-prometheus-ext). This code was adapted from upstream Prometheus server, and the comment came with the original code.

StevenYCChou commented 5 years ago

As the intended behavior is to not drop data, I think we should remove the metric dropped_samples_total. no place in the code increase/decease this metric either. What do you think?