search

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
120 stars 43 forks source link

Remove replace logic for thrift repo. #177

Closed StevenYCChou closed 4 years ago

StevenYCChou commented 4 years ago

Fixes https://github.com/Stackdriver/stackdriver-prometheus-sidecar/issues/176 .

qingling128 commented 4 years ago

Is my understanding correct that this PR fixed the issue because git.apache.org is back online?

StevenYCChou commented 4 years ago

Is my understanding correct that this PR fixed the issue because git.apache.org is back online? Yes.

However, I couldn't reproduce the issue of #176 anymore. Seems like make test will work now.

I think the TODO comment you left are still valid if git.apache.org goes down, so I'd like to keep the replacement logic. Will close this PR now.