search

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
120 stars 43 forks source link

Moving location of statuszTmpl #206

Closed fifiug closed 4 years ago

fifiug commented 4 years ago

When trying to run $GOPATH/bin/stackdriver-prometheus-sidecar --help ,I get error panic: open statusz-tmpl.html: no such file or directory. Moving the intialization of the statuszTmpl to func ServeHTTP which allows the use of --help

fifiug commented 4 years ago

I decided to go with using a const that holds the template since I wasn't able to find a way to build the template into a go binary. Please let me know if that commit works

igorpeshansky commented 4 years ago

Maybe this?

jkohen commented 4 years ago

LGTM. @StevenYCChou you own this review, please merge when you're satisfied with it.

StevenYCChou commented 4 years ago

@fifiug can you ensure the test passes?

fifiug commented 4 years ago

@StevenYCChou test passed. My pull request can't access the COVERALLS_TOKEN so "make goveralls" fails