search

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
120 stars 43 forks source link

Add ProxyV2 resource map #240

Closed msukruth closed 4 years ago

StevenYCChou commented 4 years ago

Add the expected order to the test function TestResourceMappingsOrder. An example can be found: https://github.com/Stackdriver/stackdriver-prometheus-sidecar/pull/189/files#diff-df24886d8b2bea2712e71ffcae5f1db7R231-R236

@msukruth can you also update this test function?

StevenYCChou commented 4 years ago

Travis build fails caused by coverall; the actual test are done in https://travis-ci.com/github/Stackdriver/stackdriver-prometheus-sidecar/builds/171465978 as 

ok      github.com/Stackdriver/stackdriver-prometheus-sidecar/retrieval 2.293s  coverage: 89.0% of statements