search

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
120 stars 43 forks source link

Document and fix recorded metric forwarding #266

Closed n-oden closed 2 years ago

n-oden commented 3 years ago

This should address most of https://github.com/Stackdriver/stackdriver-prometheus-sidecar/issues/104

Also: allow overriding docker FROM target with DOCKER_IMAGE_BASE env var (helpful for testing and runtime scenarios where /bin/sh is needed)

n-oden commented 3 years ago

The build failure here seems to be unrelated to the PR:

Makefile:98: *** COVERALLS_TOKEN is undefined, follow https://docs.coveralls.io/go to create one and go to https://coveralls.io to retrieve existing ones.  Stop.
The command "make goveralls" exited with 2.
igorpeshansky commented 3 years ago

The COVERALLS_TOKEN error was fixed in #274. You probably need to rebase anyway to fix the conflicts.

n-oden commented 3 years ago

Hey @igorpeshansky thanks for the feedback! Sorry I haven't been able to get to this yet but it's on my last for May.

n-oden commented 2 years ago

So, uh, obviously this is a bit later than May. But I've updated the PR with all of your comments hopefully addressed, and it's running happily in our testing environment!

n-oden commented 2 years ago

@igorpeshansky happy new year! Sorry for letting this slide for so long since your review; if you get a moment I think it's more or less good to go now.

n-oden commented 2 years ago

@davidbtucker @igorpeshansky gentle ping :)

n-oden commented 2 years ago

@davidbtucker @igorpeshansky gentle re-ping :)

Sorry to be a pest about this; if it sweetens the pot at all, what I'm hoping to get out of this is a nice long public blog post about how to use the sidecar to pull metrics out of GKE clusters using the Linkerd service mesh (rather than Istio) and get them into Google Service Monitoring as SLOs.

n-oden commented 2 years ago

@igorpeshansky no worries -- multiple months of the lag were on my end so I'm in no position to cast stones. Looking forward to getting this merged!

Once it is, can I agitate for an 0.11 release?

igorpeshansky commented 2 years ago

Once it is, can I agitate for an 0.11 release?

This was a bug fix, not a new feature, so we didn't bump the minor version. 0.10.1 has just been released.