Assumptions about order of ReadDir results in tail/tail.go

Stackdriver / stackdriver-prometheus-sidecar

A sidecar for the Prometheus server that can send metrics to Stackdriver.

https://cloud.google.com/monitoring/kubernetes-engine/prometheus

Apache License 2.0

120 stars 43 forks source link

Assumptions about order of ReadDir results in tail/tail.go #268

Open jmacd opened 3 years ago

jmacd commented 3 years ago

Reporting this bug discovered in an downstream fork of this repository, here:

https://github.com/lightstep/opentelemetry-prometheus-sidecar/issues/69

This can result in the sidecar exiting with a bogus corruption message when in fact nothing is wrong.

The fix is simple, see the associated PR. If it pleases a maintainer of this code, consider looking at other downstream changes in tail/tail.go that are relevant here (see listSegments()).