search

Stackdriver / stackdriver-prometheus

Prometheus support for Stackdriver
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
19 stars 12 forks source link

Create a distinct build path for docker to prevent compilation issues. #1

Closed bmoyles0117 closed 6 years ago

bmoyles0117 commented 6 years ago

This PR resolves that make docker, up until now, has only produced a viable docker image when the host was ALSO linux/amd64.

If I am an OSx user, and I used make build, that would provide a suitable binary for me on OSx, but it would not provide a suitable binary for the base docker image quay.io/prometheus/busybox:latest.

Creating a distinct make build-linux-amd64, and having make docker depend on that step ensures that the produced docker image will be able to run on quay.io/prometheus/busybox:latest without issue.

jkohen commented 6 years ago

Never mind my request, now I see your comment. It wasn't visible in the link I got over email.