search

Stackdriver / stackdriver-prometheus

Prometheus support for Stackdriver
https://cloud.google.com/monitoring/kubernetes-engine/prometheus
Apache License 2.0
19 stars 12 forks source link

Make metric prefix configurable and make project information config optional #19

Closed bianpengyuan closed 5 years ago

bianpengyuan commented 5 years ago

Also fetch project metadata (project id, cluster, location) from metadata server to avoid customized config.

@ostromart

bianpengyuan commented 5 years ago

@jkohen

jkohen commented 5 years ago

Peter, Travis keeps timing out. Compare the log against the last green one, https://travis-ci.com/Stackdriver/stackdriver-prometheus/builds/86872215. I think it's getting stuck in the "stackdriver" directory. Can you confirm whether it's related to your changes?

bianpengyuan commented 5 years ago

@jkohen Yeah it is indeed caused by test. Updated and it is passing now.

bianpengyuan commented 5 years ago

@bmoyles0117 gentle ping.

bianpengyuan commented 5 years ago

@bmoyles0117 Ping. Could you please take a another look? Thanks! @jkohen How does the release of this component work? Could you please help us to do a release with this PR? Thanks!

bmoyles0117 commented 5 years ago

@bianpengyuan I'm very sorry for the feedback latency, I'll be more responsive on your next commit!