search

StadlerlabRice / WW-CoV2-project

Plotting qPCR and ddPCR data for WWTPs
0 stars 1 forks source link

Date Column In Report #37

Closed DavidZong closed 3 years ago

DavidZong commented 3 years ago

Fix date column in the report to match the date that the sample was collected.

DavidZong commented 3 years ago

in 2-calculations_multiple_runs.R

mutate(Date = title_name %>% str_extract('[:digit:]{3,4}') %>% str_replace('([:digit:]+)([:digit:]{2})', '\1/\2/20') ,

This line needs to be changed to look at the sample date. Not the date written in the title

DavidZong commented 3 years ago

1203-1217 Rice Bayou TEST manhole samples.xlsx

Still not right yet. See rows with 12/17. The date still reads 12/16.

This is probably caused by the harmonize_week() function which should be run on WWTP samples but not on Bayou or Manholes.

I'll work on this bug today.

ppreshant commented 3 years ago

Oh, sorry. That was actually intentional for the WWTP samples - since we use both Monday and Tuesday dates, I changed the tuesday ti Mondays date..

I have to not do this for bayou and manhole samples, maybe will put a if condition with a switch. I will work on it tonight.

On Tue, Dec 22, 2020, 10:34 AM David Zong notifications@github.com wrote:

1203-1217 Rice Bayou TEST manhole samples.xlsx https://github.com/ppreshant/WW-CoV2-project/files/5730978/1203-1217.Rice.Bayou.TEST.manhole.samples.xlsx

Still not right yet. See rows with 12/17. The date still reads 12/16. I'll work on this bug today.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ppreshant/WW-CoV2-project/issues/37#issuecomment-749639782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRLCH3WXVHAIQL6UACGUO3SWDDARANCNFSM4VDJWOJQ .

ppreshant commented 3 years ago

Since WWTP names are hard-coded and only Monday dates are used henceforth, Harmonize_week() has been removed in the B117_pipeline_integration branch