StageShastra / public_html

0 stars 0 forks source link

Sorting needs cleaning up especially with pagination #109

Open CastikoConnectBot opened 7 years ago

CastikoConnectBot commented 7 years ago

When you go from one page to another, the sorting state refreshes. It shouldn't.

┆Issue is synchronized with this Asana task ┆Attachments: sorting increasing age.jpg | sorting decreasing age.jpg

CastikoConnectBot commented 7 years ago

➤ Dilip Kumar commented: Sorting is done by a plugin we are using. with each pagination, we are re-populating the whole table, so it is like a new table for the plugin and prev data removed. I made a hack but it is not fully accurate. It will record sorting and carry to next page but only sort data in that page of the table not from whole table data.

CastikoConnectBot commented 7 years ago

➤ Dilip Kumar commented: partially done...

CastikoConnectBot commented 7 years ago

➤ Shiv Tandan commented: https://app.asana.com/0/112389126567473/112389126567473 OK keep working on this, this is a very important issue.

CastikoConnectBot commented 7 years ago

➤ Shiv Tandan commented: https://app.asana.com/0/192239205396315/192239205396315 please add you screenshot.

CastikoConnectBot commented 7 years ago

➤ Divija Kumar commented: That one was when I sorted the data based on increasing age

CastikoConnectBot commented 7 years ago

➤ Divija Kumar commented: This one is when I sort the data based on decreasing age

CastikoConnectBot commented 7 years ago

➤ Dilip Kumar commented: I couldn't find any problem except sorting is not working after pagination. That I had fixed partially. And https://app.asana.com/0/192239205396315/192239205396315 in sorting based on decreasing age, you might had clicked sex, instead of age, I can see in the second image that it sort based on Sex.

CastikoConnectBot commented 7 years ago

➤ Divija Kumar commented: If that was the case, then the 10year old guy should have come after the 8 year old... Scroll down... And you'll notice... In the increasing age list, the 8 year old guy comes in the end...

CastikoConnectBot commented 7 years ago

➤ Shiv Tandan commented: No the issue is that the sort thinks "8" is larger than "43". I think because you're comparing them as alphabetical strings.

CastikoConnectBot commented 7 years ago

➤ Shiv Tandan commented: Also sorting state cannot refresh every time you change pages. People put a sort filter on so that they can browse the db that way. It's strange to have to do it again on everypage.

CastikoConnectBot commented 7 years ago

➤ Prashant Kiran commented: Use

int float string

whichever is suitable. Currently its all set to string

CastikoConnectBot commented 7 years ago

➤ Dilip Kumar commented: Done already

CastikoConnectBot commented 7 years ago

➤ Prashant Kiran commented: age pe data-sort string hi hai na, ya have you changed?

CastikoConnectBot commented 7 years ago

➤ Dilip Kumar commented: changed in latest commit, check GIT branch CDP