search

StalkR / goircbot

Go IRC Bot
https://godoc.org/github.com/StalkR/goircbot
Apache License 2.0
37 stars 8 forks source link

Implement functional options #21

Closed quite closed 5 years ago

quite commented 5 years ago

Sry, i'm too used to force-pushing revisions like this, but it's perhaps not the best choice for github...

StalkR commented 5 years ago

Sry, i'm too used to force-pushing revisions like this, but it's perhaps not the best choice for github...

Yes I think github wants separate commits to be able to diff them in their code review process, since there's no concept of snapshot like other systems have. Anyway don't worry about multiple commits I'll squash and merge into one.

StalkR commented 5 years ago

Looks good to me, shall I merge now or you have more changes pending?

quite commented 5 years ago

No, I'm done.