search

Stamplay / stamplay-js-sdk

:rocket: JavaScript SDK of Stamplay cloud platform
https://stamplay.com
MIT License
88 stars 18 forks source link

aws-keys.json is required by gruntfile but not included. #32

Closed isaiahgrey93 closed 8 years ago

isaiahgrey93 commented 8 years ago

The grunt configuration reads from an aws-keys.json file but this file is ignored. Cloning and building will break. Resolved temporarily by adding a empty local aws-keys.json.

claudiopetrini commented 8 years ago

The file aws-keys.json is in the .gitignore to avoid credentials leaks. The file is used to get keys for uploading files to S3, and must have AWSAccessKeyId and AWSSecretKey keys.

isaiahgrey93 commented 8 years ago

Yes of course. What I meant was that for contributors cloning the project, it will not build until they add an empty aws-keys.json file even though they will not need this file.

criroselli commented 8 years ago

Fixed with #2ea91e7