StampyAI / AISafety.com

Issue tracker for AISafety.com
1 stars 0 forks source link

/home: Escaping video doesn't work on all devices #27

Closed plexish closed 7 months ago

plexish commented 8 months ago

The X for the video window isn’t visible on certain devices. Escape doesn’t work to exit

bryceerobertson commented 8 months ago

Also: video doesn't pause automatically when user exits.

bryceerobertson commented 8 months ago

Also: clicking above or below the video doesn't exit out.

bryceerobertson commented 8 months ago

Fixed:

Partially fixed:

melissasamworth commented 7 months ago

I imagine let's address this in the technical call with nemo. I'll prep for that call by trying to have a good understanding of how to integrate custom code.

melissasamworth commented 7 months ago

@ricewithabee could you recenter the X? :)

bryceerobertson commented 7 months ago

@ricewithabee could you recenter the X? :)

Done. I made it a little bigger for you too.

bryceerobertson commented 7 months ago

Will discuss with Nemo next week.

melissasamworth commented 7 months ago

Update: Nemo tries quick fix, if it doesn't work forget it (change to low priority)

bryceerobertson commented 7 months ago

@mruwnik if it's easy enough to do, I think we should make the video automatically start. This will (mostly) avoid the ESC issue, since the user is less likely to click inside the modal (e.g. pressing Start) and therefore won't cause YouTube to start capturing keystrokes.

Here's an example: https://www.vastspace.com/

melissasamworth commented 7 months ago

@ricewithabee yes i wanted this just didn't know how!

mruwnik commented 7 months ago

how about now?

bryceerobertson commented 7 months ago

Yaaass queen 🙏🏼

melissasamworth commented 7 months ago

Everything is right in the world. It's like alignment was just solved.