search

StampyAI / stampy-ui

AI Safety Q&A web frontend
https://aisafety.info
MIT License
35 stars 9 forks source link

Make search compatible with screen readers #13

Closed plexish closed 1 year ago

tayler6000 commented 1 year ago

@Aprillion do you know if this has been done already? If so, will you close this issue?

Aprillion commented 1 year ago

I think @mruwnik made some improvements in keyboard navigation of search, but not sure if anyone actually tested the site with actual screen reader yet...

@plexish - it might be a good idea to find some accessibility testing volunteer to make a review of the site, if there are some low hanging improvements we should make

mruwnik commented 1 year ago

This. There were a few incidental improvements, but until someone with an actual reader checks it, this is pretty much blocked

plexish commented 1 year ago

Okay, I'll mention this in my next volunteer call.

tayler6000 commented 1 year ago

I tried out ui.stampy.ai and aisafety.info with iOS VoiceOver and I think there is definitely some improvements we could make. But at least for the search bar, that seemed totally fine to me. The only thing I noticed was that with the plus in ＋ None of these: Request an answer to my exact question above was pronounced in a Japanese accent on my phone, so I don't know if we're using some weird unicode + and not ASCII or if my phone was just confused because my phone can do both English and Japanese.

Aprillion commented 1 year ago

I can live with Japanese accent without understading why, closing this issue. We can open new issues with screen reader improvements when people discover more issues, but no need to keep this one open at this time.

(FTR if any contributor wants to make a PR with accessibility improvements, feel free to do so without creating an issue first - we will treat those as bug fixes, not as new features that might need a discussion before merging)