StampyAI / stampy-ui

AI Safety Q&A web frontend
https://aisafety.info
MIT License
35 stars 9 forks source link

Glossary word popover #366

Closed melissasamworth closed 8 months ago

melissasamworth commented 9 months ago

Update (12 Feb)

Acceptance criteria

Link https://www.figma.com/file/qqfeYAh6Z7QdyJXsQjIUfh/Stampy?type=design&node-id=2073%3A8816&mode=dev&t=5zH2EaswPLkKJBPS-1

melissasamworth commented 9 months ago

@mruwnik

Can you make it so the word is not repeated twice?

Image

In cases like "agentic" can you just make the word "agent" show?

Image

I also want it to appear under the word rather than to the right, and some styling fixes but I think I can probably fix all that.

mruwnik commented 9 months ago

That's mainly a copy issue, see the glossary doc. Each glossary item has a main phrase and aliases, all of which will be underlined. Do you always want the main phrase to be the bold word, even if a different word is underlined in the main text?

melissasamworth commented 9 months ago

Update:

melissasamworth commented 9 months ago

Melissa get in touch with copy

melissasamworth commented 9 months ago

Update: Use term instead of alias

melissasamworth commented 8 months ago

Update: the term looks right, just checking to make sure the ellipsis will appear

Then just a few small styling things

Image

(sorry)

melissasamworth commented 8 months ago

Why is the line height off? Did you use the class .paragraph-small? (sorry, line height is one thing I'm a bit of a perfectionist about)

Image

melissasamworth commented 8 months ago

also seems more text appears after the ellipsis

Image

melissasamworth commented 8 months ago

update: Melissa fix line height

melissasamworth commented 8 months ago

update: last issue is just that there is a bug on brave where there is more text after the ellipsis