StampyAI / stampy

A Discord bot for the Robert Miles AI server
37 stars 9 forks source link

Rewrite alignment newsletter module #229

Closed Lovkush-A closed 1 year ago

Lovkush-A commented 1 year ago

initially intention was to only introduce typehints, but I ended up making many changes so better to have separate PR.

note that there should be no changes to functionality with this pr

Changes include:

Lovkush-A commented 1 year ago

there is unusual bug with s, test yourself, where the test response is somehow lost.

TEST_RESPONSE 25: This seems relevant:
Adversarial Examples Are Not Bugs, They Are Features
...
TEST_RESPONSE 26: No matches found in the Alignment Newsletter Database
...
QUESTION # 25: FAILED
The sent message was 'TEST_QUESTION 25: paper search bugs features'
the expected message was 'REGULAR EXPRESSION: This seems relevant:\n.?Adversarial Examples Are Not Bugs, They Are Features'
the received message was 'NEVER RECEIVED A RESPONSE'
QUESTION # 26: FAILED
The sent message was 'TEST_QUESTION 26: blog post search: thisisnotarealword'
the expected message was 'No matches found in the Alignment Newsletter Database'
the received message was 'NEVER RECEIVED A RESPONSE'
Lovkush-A commented 1 year ago

made most of aesthetic suggestions as suggested by @MatthewBaggins. thanks for the review!