search

Stan15 / TAB2XML

A software that converts drum, guitar and bass tablature in text format into the musicxml format.
Creative Commons Attribution Share Alike 4.0 International
1 stars 29 forks source link

Grace notes are not being parsed right #13

Closed gilmore35 closed 3 years ago

gilmore35 commented 3 years ago

ID# 13

Who raised it: Abhirami Venugopal, abhirami@my.yorku.ca

Version: March 23,2021 version of software

Platform: Windows 10, Eclipse version 4.8.0, JavaSE-15

MusicXML viewer: SoundSlice (https://www.soundslice.com/musicxml-viewer/)

Reproduction:

  1. Open the app
  2. Paste guitar_grace.txt into the text area
  3. Click the “Convert” button
  4. Download the output file
  5. Upload to SoundSlice to test

Expected: When the generated output file is uploaded onto SoundSlice, the sheet music would like this: a

In the musicXML file itself, grace tag should be opened inside the 4th note. bb

Actual: When the output file is uploaded into SoundSplice, this is the sheet music generated. Notice that some notes before grace are wrong. a

In the musicXML file itself, no grace tag is opened inside the 4th note. I have highlighted the differences in yellow, the step and octave of the 4th note is generated wrong. cc

Priority: Medium. Caprico Arabe doesn’t contain any grace notes thus you will be able to parse that without issues. However, grace notes are in the scope of this course thus the output must be corrected and grace tags must be generated in the right place.

Severity: Medium. Grace notes don’t appear in all guitar tabs. The bug will be encountered only on occasion.

Stan15 commented 3 years ago

Hi. thanks for letting us know. At the time, support for grace notes had not been added. However, grace notes support has been added in the latest version of our software.