search

StanAngeloff / php.vim

An up-to-date Vim syntax for PHP (7.x supported)
477 stars 69 forks source link

Docker image on docker hub #53

Closed codemedic closed 6 years ago

codemedic commented 8 years ago

Please can you build the docker image on docker hub; so that it is readily consumable for docker newbies. Otherwise, it takes ageeees to build.

Thanks

StanAngeloff commented 8 years ago

Hi @codemedic,

The image is not meant to be used by newbies. It is used during development to re-generate the syntax/php.vim file with the latest version of PHP available. The process updates constants, functions, classes, etc.

There is no value in having the image up on Docker Hub since the syntax/php.vim file will always be up-to-date.

Did the README prompt you to build the Docker image yourself as you thought this was needed to get the syntax to work?

codemedic commented 8 years ago

Oh, OK. I didn't know that.

Yes, the README did make me wonder if I should run it to bring it upto date (with the PHP version I had on my box; only 5.6). I wonder if it is worth adding a little note of some kind to say that it is only for development purposes.

Thanks

StanAngeloff commented 6 years ago

README has been updated to note using Docker is not needed unless you plan on updating the syntax file yourself.