StanAngeloff / php.vim

An up-to-date Vim syntax for PHP (7.x supported)
477 stars 69 forks source link

Fix some unintended matches outside of '<?php' #67

Closed adriaanzon closed 7 years ago

adriaanzon commented 7 years ago

This adds the contained argument to some syn match calls, to prevent them from matching outside of a php region. It was mostly unnoticeable, but some examples of bad matches were:

Here's a before and after:

before after
screenshot from 2017-01-29 00-45-35 screenshot from 2017-01-29 00-54-47

I tested it out for a while and it didn't seem to have any side effects whatsoever.

StanAngeloff commented 7 years ago

Thanks @adriaanzon! I've reviewed those locally and all seems to be in order.

I appreciate the neat pull request and the nicely formatted commit message :star: