search

StanAngeloff / php.vim

An up-to-date Vim syntax for PHP (7.x supported)
477 stars 69 forks source link

Fix for namespaces in phpDocTag highlighting #72

Closed jrebs closed 7 years ago

jrebs commented 7 years ago

I chopped at this line a bit to get it to behave expectedly when doctagging namespaced classes. It seems to work OK here. Would like feedback from someone who understands it better.

Should be fix for https://github.com/StanAngeloff/php.vim/issues/57

StanAngeloff commented 7 years ago

Thanks for the pull request. I've merged in a commit which re-uses the syntax from phpClassExtends which should be correct. Let me know if it works for you!

Thanks for your contribution :star:

jrebs commented 7 years ago

Thanks for the quick patch, Stan. Have you ever considered also separating the doctag param var_name from the param short description so that they are also distinguished? I mean a fourth group, like:

/**
 * @param type $identifier _<short description>_
 */

In a generated output, I would expect the $identifier and shortdesc to be distinct, maybe by italics on the desc. It would be nice if there was a way to do this in the vim syntax overriding as well. I thought maybe applying phpFunction colour to the $identifier and leaving the rest as the phpComment. Problem is, of course, it's a bit beyond my abilities to work out the logistics. If you agree that this would be worthwhile, at least, I could put a feature request in and maybe someone will have the interest, or I'll figure it out before them.