search

StanJulia / StanSample.jl

WIP: Wrapper package for the sample method in Stan's cmdstan executable.
MIT License
18 stars 4 forks source link

Minor fix to `cmd` generation #55

Closed andrewjradcliffe closed 2 years ago

andrewjradcliffe commented 2 years ago

This PR fixes accidental override of the term_buffer CmdStan arg with init_buffer.

goedman commented 2 years ago

Hi Andrew, thanks for your PR. I’m currently traveling without my laptop computer so I can’t test this fix. I did merge the PR but can’t do much more until Aug 29 when I have access to my computer again.

goedman commented 2 years ago

It looks like the merge worked fine. When/how did you encounter this issue? Let me If you need this urgently and I’ll try to merge it asap

andrewjradcliffe commented 2 years ago

Hi Rob, thanks for the quick reply. I discovered this when I was looking through the log files from a Stan run and noticed that term_buffer did not have the value supplied to the SampleModel constructor. I then checked the cmdline function and found the source. The backstory is that I use StanSample/StanBase machinery insofar as possible, but provide a simple modification to the stan_cmds function so that I can supply extra options such as sig_figs=18. I should clean the code up and submit a PR, but I have been dragging my feet for nearly a year...

goedman commented 2 years ago

For now I’ve created an issue to look into this when I have access to my computer again. I would like the SampleModel to indeed hold all possible arguments (a PR is of course always welcome).