search

StanJulia / StanSample.jl

WIP: Wrapper package for the sample method in Stan's cmdstan executable.
MIT License
18 stars 4 forks source link

Fix issue with extra arguments being ignored #77

Closed zeyus closed 2 months ago

zeyus commented 2 months ago

Most of the configurable options that should be passed to cmdstan were getting ignored, this just passes along the kwargs so that the final command executed includes the correct settings.

goedman commented 2 months ago

Thanks @zeyus, merged your pull request in v7.10.0. Should be published in the next hour or so.

zeyus commented 2 months ago

@goedman Amazing, thanks :)

goedman commented 2 months ago

@zeyus You're welcome.

If you have an example of using your fix, I wouldn't mind adding it as a test.

zeyus commented 2 months ago

If you have an example of using your fix, I wouldn't mind adding it as a test.

No probs, I have created a new PR with a test and due to that process discovered a couple of minor issues along the way.

https://github.com/StanJulia/StanSample.jl/pull/78