search

StanWarford / pep9suite

Pep9Suite is a suite of software for the Pep/9 virtual machine described in the text Computer Systems, J. Stanley Warford, fifth edition.
http://computersystemsbook.com
Other
16 stars 7 forks source link

display cropping issue in memory trace visualization #118

Open fstonedahl opened 2 years ago

fstonedahl commented 2 years ago

On Linux (HiDPI screen) - the stack memory visualization (based on traced tags) is cutting off the first digit of the memory addresses -- as shown here (stepping through Figure 6.4):

image

(I tried changing the "Font Size" to see if that would fix it, but that does not seem to affect the text size of the memory visualization).

Matthew-McRaven commented 2 years ago

Good catch! I suspect that I didn't anticipate users switching to larger-than-default fonts here.

This is being tracked, and will be fixed in the next version.

fstonedahl commented 2 years ago

I've confirmed that this is a "HiDPI screen issue". (It might also just be a Linux-only HiDPI issue - I don't have a HiDPI windows machine to test it on right now.)

More information:

In Mint Linux (Cinnamon desktop), when I change my desktop user interface scaling to Normal 1:1 instead of Double 2:1, then the memory visualization text doesn't get cut off... it's just really small on my hi-resolution laptop screen).

And, when I am in my normal double scaling setting, it looks like it fixes the issue for me if I set this QT environment variable before running Pep9:

QT_SCREEN_SCALE_FACTORS=2 pep9

If there's some way to fix it on your end so that it scales correctly "out of the box" that'd be great, but at least I have a workaround now in any case.

fstonedahl commented 2 years ago

Update: there might also be a problem with printing the source code, where the print font is too large and getting clipped off.

(example of clipping problem from a print-to-pdf) image

Again, I suspect "HiDPI" issues are at play. (However, this printing issue occurred even after I had set the QT_SCREEN_SCALE_FACTORS=2 environment variable... so I guess that wasn't a panacea.)

Matthew-McRaven commented 2 years ago

Interesting find on the print there. I remember in the past that HDPI support in Qt hasn't worked the best, and I think that' what we're seeing here.

Very surprised by the print bug though, as Qt's printing object should be able to handle this case out of the box.

fstonedahl commented 2 years ago

At one point I changed the font size, and it did work without clipping... so I'm not quite sure what the printing-related issue is. Not a big issue in any case...