fig0640 trace tag warning missing

StanWarford / pep9suite

Pep9Suite is a suite of software for the Pep/9 virtual machine described in the text Computer Systems, J. Stanley Warford, fifth edition.

http://computersystemsbook.com

Other

16 stars 7 forks source link

fig0640 trace tag warning missing #80

Closed StanWarford closed 4 years ago

StanWarford commented 5 years ago

In pep9asm Figure 6.40 guess: .EQUATE 0 ;local variable #2d if you omit the format trace tag guess: .EQUATE 0 ;local variable a blue warning message should be triggered on the SUBSP line. The code executes as expected without the visual debugger, but there should be a warning message.

Matthew-McRaven commented 4 years ago

This is now fixed in Pep/10. However, Pep/10 uses an entirely different assembler architecture. Let me see if I can come up with a minimum replicating example, and construct a bugfix.

Matthew-McRaven commented 4 years ago

The minimum program reproducing the error:

ADDSP   2,i         ;pop #guess
.END

The issue seems to be that any program lacking format tags (#1c, #2d) will not trigger our trace tag resolver. I added code that will cause (malformed) programs only containing symbol trace tags to go through our trace tag resolver.

Matthew-McRaven commented 4 years ago

Will you confirm that the latest version of master fixes this bug?

StanWarford commented 4 years ago

Tested, fixed.