StanWarford / pep9suite

Pep9Suite is a suite of software for the Pep/9 virtual machine described in the text Computer Systems, J. Stanley Warford, fifth edition.
http://computersystemsbook.com
Other
16 stars 7 forks source link

Pep9CPU inconsistent MDRMux highlighting. #85

Closed Matthew-McRaven closed 4 years ago

Matthew-McRaven commented 4 years ago

MDRMux will not be highlighted unless MDRCk is set and there is a valid data flow through the MDRMux.

This is in contrast to the CMux, which will color itself and the C bus as long as there is valid data leaving CMux, even if that data is not clocked in to a register.

For consistency with the rest of the Pep9CPU application, all MDR multiplexers should be highlighted if data is flowing through them, even if the data value will not be clocked. More generally, every multiplexer in the application should have this behavior.

Screen Shot 2019-11-21 at 00 30 35

This bug inconsistency is also present in the two-byte model with MDREMux, MDROMux.

StanWarford commented 4 years ago

Good observation. I agree all mux's should have this behavior.

Matthew-McRaven commented 4 years ago

Fixed with 71fe7aa6e5148a051a82f4d8128eedfad0f54d51.

Also fixed in Pep10Suite with 85f2c53.