Standard-Labs / real-intent

Python SDK and abstracted interface for Real Intent operations.
https://realintent.co
0 stars 0 forks source link

Warn if Follow Up Boss leads are on DNC #63

Closed preritdas closed 3 months ago

preritdas commented 3 months ago

Fixes #61.

Log a warning if a Follow Up Boss deliverer is told to deliver at least 1 lead with a phone number on the DNC list.

Applies to vanilla and AI deliverers.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes involve the removal of the _deliver method in the ai_fields.py file, which previously managed the delivery of PII data to FollowUpBoss. Additionally, a new private method _warn_dnc has been added in vanilla.py to log warnings for leads on the Do Not Call list, enhancing validation within the lead delivery process.

Changes

Files Change Summary
bigdbm/deliver/followupboss/ai_fields.py Removed the _deliver method that handled PII data delivery.
bigdbm/deliver/followupboss/vanilla.py Introduced _warn_dnc method for DNC list warnings; modified _deliver to incorporate this check.

Assessment against linked issues

Objective Addressed Explanation
Warn if DNC in Follow Up Boss delivery (#61)

🐰 In fields of code where changes sprout,
A warning for DNC, we now tout!
The old method gone, a new path clear,
Delivering leads with caution, my dear!
Hoppity hop, to a safer day,
With every lead, we’ll find our way! 🌼


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.