Closed preritdas closed 2 months ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces modifications to the email body construction in the _email_body
method of the real_intent/deliver/kvcore/__init__.py
file. Additionally, it adds a new function and a pytest fixture in tests/conftest.py
for generating random names and sample PII data, respectively. The changes also involve the removal of previously defined functions and fixtures in tests/test_followupboss.py
. A new test file, tests/test_kvcore.py
, is created to validate the email body generation of the KVCoreDeliverer
class.
Files | Change Summary |
---|---|
real_intent/deliver/kvcore/__init__.py |
Modified the _email_body method to change how the email is constructed by appending the first email object instead of its email attribute. |
tests/conftest.py | Added generate_random_name(length=6)function and sample_pii_md5s` pytest fixture for generating random names and structured PII data for testing. |
|
tests/test_followupboss.py | Removed generate_random_namefunction and sample_pii_md5s` fixture. |
|
tests/test_kvcore.py | Introduced new tests for KVCoreDeliverer`, specifically validating the email body generation with assertions on personal information fields. |
_email_body
method in the real_intent/deliver/kvcore/__init__.py
file, which is directly related to the changes made in the main PR regarding how the email body is constructed.🐰 In a world of code and light,
A rabbit hops with joy so bright.
New names to share, and tests to run,
Email bodies crafted, oh what fun!
With every change, we leap and cheer,
For better code is finally here! 🐇✨
Early access features: enabled
Was previously using an incorrect mechanism of retrieving a lead's email addresses.
Summary by CodeRabbit
New Features
Bug Fixes
Tests