search

StandardCyborg / StandardCyborgCocoa

Everything you need for 3D scanning on iOS
https://www.standardcyborg.com
Other
143 stars 49 forks source link

Revert “Update ScanningViewController.isCameraPaused to be a derived value" #16

Closed irtemed88 closed 3 years ago

irtemed88 commented 4 years ago

Turns out the management of this state is a bit more fragile than I originally thought. The underlying session is modified asynchronously meaning in some cases the reading of the top-level paused value could be incorrect.

We’ll need to take a deeper more thoughtful dive into this in the future if we want to keep the value derived.

Also with this change we revert the isFocusLocked since the both changes were necessary to support my new implementation (the one we’re reverting)

irtemed88 commented 3 years ago

Looks good - can you confirm you tested in StandardCyborgExample too?

@jeffchuber - Yep I built + ran StandardCyborgExample with the change and scanning is still working. If there was an issue I think a simple test would have caught it since I was observing strange behavior like the camera freezing up or crashing in unexpected places.

If this looks good lmk and I'll merge.

jeffchuber commented 3 years ago

@irtemed88 sounds good!