StandardCyborg / StandardCyborgCocoa

Everything you need for 3D scanning on iOS
https://www.standardcyborg.com
Other
143 stars 49 forks source link

Replace ObjectMapper with Swift Codable #2

Closed irtemed88 closed 4 years ago

irtemed88 commented 4 years ago

This PR replaces the ObjectMapper library with Swift's native Codable implementation. Additionally, this PR also makes performJSONOperation templated so the compiler can automatically infer the types being read from server operations (eliminating the need for casting Any => expected type.

The swift compiler can synthesize serialization code so we don't always need to write the boilerplate for reading objects to/from JSON.

irtemed88 commented 4 years ago

@aaptho - All of your PR feedback should be addressed with my latest push. Want to give that a look and let me know if there's anything else? Thanks!