search

StandardCyborg / StandardCyborgCocoa

Everything you need for 3D scanning on iOS
https://www.standardcyborg.com
Other
143 stars 49 forks source link

StandardCyborgUI: fix file reference #21

Closed jeffchuber closed 2 years ago

jeffchuber commented 3 years ago

StandardCyborgUI/StandardCyborgUI.xcodeproj/project.pbxproj still referenced PointCloudPreviewViewController.swift and PointCloudPreviewViewController.scn even though we switched to ScenePreviewViewController.swift, and ScenePreviewViewController.scn. This PR fixes it.

theDiegoJRR commented 3 years ago

Has there been any changes on this? I'm getting an error when trying to save a scan, and it's related to the ScenePreviewViewController class, I'm guessing this is the reason

jeffchuber commented 3 years ago

@theDiegoJRR does this PR work for you?

saamerm commented 2 years ago

@jeffchuber the new GLTF files generated don't seem to work with a lot of tools. We can't event convert the file to PLY You can see the error if you try to view any StandardCybord generated GLTF file in popular online viewers like: https://gltf-viewer.donmccurdy.com It gives this error: null is not an object (evaluating 'i.length')

Here's a test file you can use, or I can share the file in a GIST if you prefer

Is there someone I can discuss about this issue?

aaptho commented 2 years ago

@jeffchuber the new GLTF files generated don't seem to work with a lot of tools. We can't event convert the file to PLY You can see the error if you try to view any StandardCybord generated GLTF file in popular online viewers like: https://gltf-viewer.donmccurdy.com It gives this error: null is not an object (evaluating 'i.length')

Here's a test file you can use, or I can share the file in a GIST if you prefer

Is there someone I can discuss about this issue?

@saamerm that sounds like an unrelated error. While Standard Cyborg is now defunct as a corporation, we will be open sourcing the guts soon, and you may be able to fix the GLTF issues yourself.