StandardCyborg / StandardCyborgCocoa

Everything you need for 3D scanning on iOS
https://www.standardcyborg.com
Other
143 stars 49 forks source link

StandardCyborgUI podspec fixes and ScenePreviewViewController enhancements #22

Closed aaptho closed 3 years ago

aaptho commented 3 years ago

When including StandardCyborgUI in a project that already has an xcassets bundle, I was hitting this build error

Multiple commands produce '/Users/me/Library/Developer/Xcode/DerivedData/Build/Products/Debug/MyApp.app/Assets.car': 1) Target 'MyApp' (project 'MyApp') has compile command with input '/Users/me/Source/MyApp/MyApp/Images.xcassets' 2) That command depends on command in Target 'MyApp' (project 'MyApp'): script phase “[CP] Copy Pods Resources”

The fix is to move resources into a resources bundle and update the bundle loading code accordingly. This change causes CocoaPods to generate a bundle called StandardCyborgUI.bundle when compiling the pod, into which the scenes, assets, and compiled Metal library are included.

Along the way, this makes a couple improvements to the ScenePreviewViewController.

jeffchuber commented 3 years ago

thanks @aaptho ! looks great.