Accepting pathlib paths in parser - Githubissues

Stanford-NavLab / gnss_lib_py

Modular Python tool for parsing, analyzing, and visualizing Global Navigation Satellite Systems (GNSS) data and state estimates

MIT License

117 stars 30 forks source link

Accepting pathlib paths in parser #111

Closed danineamati closed 1 year ago

danineamati commented 1 year ago

Bug/Missing Functionality Navdata parser requires CSV path to be a string, but for compatibility across operating systems and better functionality, it may be useful to allow pathlib.Path objects as well.

To Reproduce pixel4_gt_path = pathlib.Path('/content/drive/path/to/train w derived/2021-04-29-US-SJC-2/Pixel4/ground_truth.csv') gt_data_pixel4 = glp.AndroidGroundTruth2021(pixel4_gt_path)

See https://github.com/Stanford-NavLab/gnss_lib_py/blob/60c35b669ad1fa1d9d53328ccf6a03a12606acc2/gnss_lib_py/parsers/navdata.py#L91-L113

Specifically, line 105 only allows strings.

System Information (please complete the following information):

Run on Google Colab (June 26, 2023)
- Python Version: Python 3.10.12