search

Stanford-Online / edx-platform

The Open edX platform, the software that powers Lagunita!
https://lagunita.stanford.edu
GNU Affero General Public License v3.0
42 stars 18 forks source link

Change button text for creating account #888

Closed cthai18 closed 5 years ago

cthai18 commented 5 years ago

Changed button text from "Register through edX" to "Create an Account" on Reigister with Institution/Campus Credentials page.

@stvstnfrd

stvstnfrd commented 5 years ago

@cthai18 Ah, you'll actually want to submit this to edx's repo; You need to update the base repo/branch when first submitting the PR.

If you can't figure it out, give a holler and someone can lend a hand.

stvstnfrd commented 5 years ago

@cthai18 Also, prior to submitting this upstream, can you amend the commit message to include further details, specifically, the motivation for this change..

I know why you're doing this, but it probably won't be as obvious to edx. The message should convey that an explicit motivation for this change is to un-hard-code the word edx; we're not just changing this for change's sake..