Closed karandikar closed 7 years ago
@karandikar Screenshot?
And did you verify this behavior when video is the first component in the unit.
@stvstnfrd Regarding behavior when video is first element: the question would appear in the correct position, but for the wrong reason. The way @caesar2164 explained it, the MVP assumed that a video would be the first component, so in-video quiz questions were hard-coded to align to where a video would be if it were the first component. When videos were no longer the first component, the in-video quiz questions would still appear over the first component area, creating the behavior described in the trello card. My fix works for all videos, whether or not they're the first component. Screenshots forthcoming
with video as first component: with video as second component:
@stvstnfrd this PR makes this xblock work the way it should work. When the JS is about to display a problem, it gets the position and height of the video and makes the problem match that.
If a video isn't the first component in the unit, the in-video-quiz questions appear incorrectly positioned on the page. This repositions the questions to properly cover the video while it's paused.