Fix in-video quiz question issues with display, sizing, and alignment

Stanford-Online / xblock-in-video-quiz

BSD 3-Clause "New" or "Revised" License

18 stars 25 forks source link

Fix in-video quiz question issues with display, sizing, and alignment #11

Closed karandikar closed 7 years ago

karandikar commented 7 years ago

This set of commits fixes issues with the question alignment when the video isn't the first component, question sizing/alignment when a video is resized (window resize or un-fullscreening) with a question open, and questions displaying inconsistently because of a css issue.

karandikar commented 7 years ago

@stvstnfrd @caesar2164 Let me know if any changes need to be made here. These changes solve the problem, but I'm aware they're inelegant/inefficient; I'll continue looking for an event I could listen for to detect a fullscreen change instead of checking every 200 milliseconds.

coveralls commented 7 years ago

Changes Unknown when pulling 438be6bf601077b0194c51f5aebf03462fd6c85e on karandikar:fix-in-video-quiz into on Stanford-Online:master.

karandikar commented 7 years ago

@caesar2164 Fixed, let me know if anything else needs to change!

coveralls commented 7 years ago

Changes Unknown when pulling d8c4310fbfee587a5fae108d3573d4598efda32d on karandikar:fix-in-video-quiz into on Stanford-Online:master.

karandikar commented 7 years ago

@caesar2164 Made the necessary edits! Let me know what you think

coveralls commented 7 years ago

Changes Unknown when pulling d191939e267ca42c36526892b5855db95241e7c2 on karandikar:fix-in-video-quiz into on Stanford-Online:master.

coveralls commented 7 years ago

Changes Unknown when pulling 55976e259becaad9475ad8086e76e3373ecd63ca on karandikar:fix-in-video-quiz into on Stanford-Online:master.

coveralls commented 7 years ago

Changes Unknown when pulling e95f2683c5cc1df870c4ac40a8c3e11279152793 on karandikar:fix-in-video-quiz into on Stanford-Online:master.

coveralls commented 7 years ago

Changes Unknown when pulling 04fa075eafc52e8e4364212ca30dfa925c234bb5 on karandikar:fix-in-video-quiz into on Stanford-Online:master.

karandikar commented 7 years ago

@stvstnfrd Made a bunch of changes based on your recommendations, let me know what you think!

coveralls commented 7 years ago

Changes Unknown when pulling e56e2aa43c767f16255d5f16fe4d2c7c2b5a18c9 on karandikar:fix-in-video-quiz into on Stanford-Online:master.

stvstnfrd commented 7 years ago

+1 lgtm, thanks for implementing those changes!

caesar2164 commented 7 years ago

@karandikar awesome, time to squash commits!

karandikar commented 7 years ago

@caesar2164 @stvstnfrd Squashed, take a look and let me know if anything needs changing!

coveralls commented 7 years ago

Changes Unknown when pulling 8abbbd6bb6a89f8bc8839716ea290ddfee56593c on karandikar:fix-in-video-quiz into on Stanford-Online:master.

coveralls commented 7 years ago

Changes Unknown when pulling 20d2a26888eed3314a4bedc55807f0c07529c7f4 on karandikar:fix-in-video-quiz into on Stanford-Online:master.