Stanford-Online / xblock-in-video-quiz

BSD 3-Clause "New" or "Revised" License
18 stars 25 forks source link

Fix videostate being undefined if YouTube API loads slowly #12

Closed karandikar closed 7 years ago

karandikar commented 7 years ago

In some instances, when the youtube API had not yet loaded, the assignment of the videoState variable would result in undefined; this led to issues of the in-video-quiz questions not appearing properly. We move the assignment to the 'play' video event, which only occurs when the API has fully loaded

@caesar2164 @stvstnfrd

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling c86fc15abd2da4d3e047956f65d715b05cff1078 on karandikar:fix-videostate into on Stanford-Online:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 88cd900282b9cd0ab762a0f6b4f30b002243d7e3 on karandikar:fix-videostate into on Stanford-Online:master.