Open informaton opened 4 years ago
Yes, you are right about the hard coded names there. The original instructions were to update the inf_config.py directly to make the changes. It sounds like it may be best and easiest for you to update the inf_config.py file's settings directly rather than following the instructions for using the json parameters because of some of the differences. Good idea about flagging unrecognized options. I'll add it as a feature request (i.e. here).
Posted for Steve:
There are still hard-coded paths in inf_config.py [lines 54-56]. Also, the JSON attributes that appear to correspond to those hard-coded variables have slightly different names in 2/3 cases. Thus the JSON inputs don't override those values, and the app tries to use a hard-coded path for a Windows system on my Linux box. From inf_config.py:
From stanford_stages.json:
And from my runtime AppConfig object when making the call to inf_narco_app:
More generally, you might consider issuing at least a warning if there are any unrecognized options in the JSON file (for catching typos, for instance).