search

StanfordAHA / CGRAFlow

Integration test for entire CGRA flow
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Srcleanup #18

Closed steveri closed 7 years ago

steveri commented 7 years ago

  1. As promised, 8x8 parrot is running and ready to merge. I pasted it on the end as a separate new test. It passed: https://travis-ci.org/StanfordAHA/CGRAFlow/builds/244270028

  2. What's the difference between "assignee" and "reviewer" for the git pull? And which one are we supposed to use? Never mind, found it: https://stackoverflow.com/questions/41087206/on-github-whats-the-difference-between-reviewer-and-assignee ... I'm the assignee and you guys are the reviewers, I guess.

steveri commented 7 years ago

I will go ahead and merge.  Thanks for the input guys! SR

  From: jameshegarty <notifications@github.com>

To: StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: steveri steveri@steveri.com; Assign assign@noreply.github.com Sent: Tuesday, June 20, 2017 12:03 AM Subject: Re: [StanfordAHA/CGRAFlow] Srcleanup (#18)

@jameshegarty approved this pull request.Looks good to me! Assuming this works, go ahead and merge! Thanks!— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

steveri commented 7 years ago

Okay I am merging now. This means that the 4x4 parrot should continue to PASS but the new 8x8 will FAIL until the PNR scripts are updated in their main branch.

steveri commented 7 years ago

Okay the merge is in place; the new test does a 4x4 CGRA and then an 8x8.  The 4x4 should continue to PASS but the 8x8 (and the overall test) will FAIL until the PNR guys check in their latest script to master (the existing script only works on 4x4). SR

  From: Stephen Richardson <ichbinsteve@yahoo.com>

To: StanfordAHA/CGRAFlow reply@reply.github.com; StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: Assign assign@noreply.github.com Sent: Tuesday, June 20, 2017 9:42 AM Subject: Re: [StanfordAHA/CGRAFlow] Srcleanup (#18)

I will go ahead and merge.  Thanks for the input guys! SR

  From: jameshegarty <notifications@github.com>

To: StanfordAHA/CGRAFlow CGRAFlow@noreply.github.com Cc: steveri steveri@steveri.com; Assign assign@noreply.github.com Sent: Tuesday, June 20, 2017 12:03 AM Subject: Re: [StanfordAHA/CGRAFlow] Srcleanup (#18)

@jameshegarty approved this pull request.Looks good to me! Assuming this works, go ahead and merge! Thanks!— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.